Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIP Quorum rotation #4512

Closed

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Oct 12, 2021

Known gaps still needed to be filled (implementation needed or investigation):

  • Error handling when InitQuorum fails to create the new quorum quarter
  • If a DKG failed at cycle at height h due to a failure, the quarters that were calculated this cycle are still taken into account for next cycles’s calculations
  • Implement SkipMode 2 when building a new CQuorumSnapshot
  • llmqType + dkgBlockHash is not enough to identify a quorum. quorumIndex should be included as well (as @UdjinM6 suggested)
  • Choosing the active llmq for signing
  • CQuorumSnapshot.activeQuorum field type should be changed to a CFixedBitset for space optimization.
  • Investigate if condensation of the quorum commitment message into a smaller batched quorum commitment message needs to be done
  • Add version 2 of CFinalCommitment when using quorumIndex in the quorumHash
  • Number of active quorums (that do rotation) needs to be a power of two
  • Number of quourm members (that do rotation) needs to be divisible by four
  • Merge DIP24 and Governance Fee as one deployment

@github-actions
Copy link

This pull request has conflicts, please rebase.

@PastaPastaPasta PastaPastaPasta modified the milestones: 17, 18 Oct 15, 2021
src/consensus/params.h Outdated Show resolved Hide resolved
src/llmq/blockprocessor.cpp Outdated Show resolved Hide resolved
src/llmq/commitment.h Outdated Show resolved Hide resolved
src/llmq/commitment.h Outdated Show resolved Hide resolved
src/llmq/dkgsession.h Outdated Show resolved Hide resolved
src/llmq/dkgsession.h Outdated Show resolved Hide resolved
src/llmq/snapshot.cpp Outdated Show resolved Hide resolved
src/llmq/snapshot.h Outdated Show resolved Hide resolved
src/llmq/snapshot.h Show resolved Hide resolved
src/rpc/rpcquorums.cpp Outdated Show resolved Hide resolved
src/rpc/rpcquorums.cpp Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

@ogabrielides ogabrielides force-pushed the quorum_rotation_dip_dev branch 2 times, most recently from fd7ec44 to bacad46 Compare October 25, 2021 08:19
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@ogabrielides ogabrielides marked this pull request as draft April 7, 2022 11:28
@ogabrielides
Copy link
Collaborator Author

@UdjinM6 @PastaPastaPasta Converted this one as a draft, since #4752 will be merged.

@PastaPastaPasta
Copy link
Member

Closing as superseded by #4752

@ogabrielides ogabrielides deleted the quorum_rotation_dip_dev branch April 18, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2P Some notable changes on p2p level RPC Some notable changes to RPC params/behaviour/descriptions
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants