From 0c66b18e46968cd5d8fac53a2e82514514a64f1b Mon Sep 17 00:00:00 2001 From: thephez Date: Wed, 3 Sep 2025 16:33:32 -0400 Subject: [PATCH 1/2] refactor(wasm-sdk): remove unused key_id parameters from document functions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove unused _key_id and key_id parameters from document state transition functions: - document_replace, document_delete, document_transfer (removed _key_id: u32) - document_purchase, document_set_price (removed key_id: u32) These parameters were never used as the functions automatically find the correct authentication key using find_authentication_key() based on the private key. Also updated index.html JavaScript calls to remove the hardcoded 0 values that were being passed for these unused parameters. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- packages/wasm-sdk/index.html | 15 +++++---------- .../src/state_transitions/documents/mod.rs | 10 ---------- 2 files changed, 5 insertions(+), 20 deletions(-) diff --git a/packages/wasm-sdk/index.html b/packages/wasm-sdk/index.html index d01c288e0c..94d5cfb543 100644 --- a/packages/wasm-sdk/index.html +++ b/packages/wasm-sdk/index.html @@ -3296,8 +3296,7 @@

Results

identityId, JSON.stringify(documentData), BigInt(loadedDocumentRevision), - privateKey, - 0 // key_id - using 0 as default + privateKey ); // Pass the result object directly to displayResult @@ -3314,8 +3313,7 @@

Results

values.documentType, values.documentId, identityId, - privateKey, - 0 // key_id - using 0 as default + privateKey ); // Pass the result object directly to displayResult @@ -3329,8 +3327,7 @@

Results

values.documentId, identityId, values.recipientId, - privateKey, - 0 // key_id - using 0 as default + privateKey ); // Pass the result object directly to displayResult @@ -3344,8 +3341,7 @@

Results

values.documentId, identityId, BigInt(values.price || 0), // price in credits, 0 to remove price - privateKey, - 0 // key_id - using 0 as default + privateKey ); // Pass the result object directly to displayResult @@ -3478,8 +3474,7 @@

Results

values.documentId, identityId, BigInt(values.price), - privateKey, - 0 // key_id - using 0 as default + privateKey ); // Pass the result object directly to displayResult diff --git a/packages/wasm-sdk/src/state_transitions/documents/mod.rs b/packages/wasm-sdk/src/state_transitions/documents/mod.rs index 8a186f2c8f..3097255ceb 100644 --- a/packages/wasm-sdk/src/state_transitions/documents/mod.rs +++ b/packages/wasm-sdk/src/state_transitions/documents/mod.rs @@ -508,7 +508,6 @@ impl WasmSdk { /// * `document_data` - The new document data as a JSON string /// * `revision` - The current revision of the document /// * `private_key_wif` - The private key in WIF format for signing - /// * `key_id` - The key ID to use for signing /// /// # Returns /// @@ -523,7 +522,6 @@ impl WasmSdk { document_data: String, revision: u64, private_key_wif: String, - _key_id: u32, ) -> Result { let sdk = self.inner_clone(); @@ -794,7 +792,6 @@ impl WasmSdk { /// * `document_id` - The ID of the document to delete /// * `owner_id` - The identity ID of the document owner /// * `private_key_wif` - The private key in WIF format for signing - /// * `key_id` - The key ID to use for signing /// /// # Returns /// @@ -807,7 +804,6 @@ impl WasmSdk { document_id: String, owner_id: String, private_key_wif: String, - _key_id: u32, ) -> Result { let sdk = self.inner_clone(); @@ -921,7 +917,6 @@ impl WasmSdk { /// * `owner_id` - The current owner's identity ID /// * `recipient_id` - The new owner's identity ID /// * `private_key_wif` - The private key in WIF format for signing - /// * `key_id` - The key ID to use for signing /// /// # Returns /// @@ -935,7 +930,6 @@ impl WasmSdk { owner_id: String, recipient_id: String, private_key_wif: String, - _key_id: u32, ) -> Result { let sdk = self.inner_clone(); @@ -1056,7 +1050,6 @@ impl WasmSdk { /// * `buyer_id` - The buyer's identity ID /// * `price` - The purchase price in credits /// * `private_key_wif` - The private key in WIF format for signing - /// * `key_id` - The key ID to use for signing /// /// # Returns /// @@ -1070,7 +1063,6 @@ impl WasmSdk { buyer_id: String, price: u64, private_key_wif: String, - key_id: u32, ) -> Result { let sdk = self.inner_clone(); @@ -1222,7 +1214,6 @@ impl WasmSdk { /// * `owner_id` - The owner's identity ID /// * `price` - The price in credits (0 to remove price) /// * `private_key_wif` - The private key in WIF format for signing - /// * `key_id` - The key ID to use for signing /// /// # Returns /// @@ -1236,7 +1227,6 @@ impl WasmSdk { owner_id: String, price: u64, private_key_wif: String, - key_id: u32, ) -> Result { let sdk = self.inner_clone(); From 1cd1c4c3ff090847439fbcedd9892cabc3c51d99 Mon Sep 17 00:00:00 2001 From: thephez Date: Wed, 3 Sep 2025 16:59:04 -0400 Subject: [PATCH 2/2] fix(wasm-sdk): remove unused keyId parameter from tokenDirectPurchase MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove keyId field from api-definitions.json - Remove keyId from test-data.js fixture - Regenerate docs without keyId parameter - Fix frozenIdentityId parameter name in AI_REFERENCE.md The keyId parameter was never used as the SDK automatically finds the correct authentication key based on the provided private key. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- packages/wasm-sdk/AI_REFERENCE.md | 3 +-- packages/wasm-sdk/api-definitions.json | 6 ------ packages/wasm-sdk/docs.html | 5 ----- packages/wasm-sdk/docs_manifest.json | 2 +- packages/wasm-sdk/test/ui-automation/fixtures/test-data.js | 1 - 5 files changed, 2 insertions(+), 15 deletions(-) diff --git a/packages/wasm-sdk/AI_REFERENCE.md b/packages/wasm-sdk/AI_REFERENCE.md index 1cd9c81ee3..23531a9e08 100644 --- a/packages/wasm-sdk/AI_REFERENCE.md +++ b/packages/wasm-sdk/AI_REFERENCE.md @@ -1097,7 +1097,6 @@ Parameters (in addition to identity/key): - `tokenPosition` (number, required) - Token Contract Position - `amount` (text, required) - Amount to Purchase - `totalAgreedPrice` (text, optional) - Total Agreed Price (in credits) - Optional, fetches from pricing schedule if not provided -- `keyId` (number, required) - Key ID (for signing) Example: ```javascript @@ -1175,7 +1174,7 @@ const result = await sdk.tokenUnfreeze(identityHex, /* params */, privateKeyHex) Parameters (in addition to identity/key): - `contractId` (text, required) - Data Contract ID - `tokenPosition` (number, required) - Token Contract Position -- `identityId` (text, required) - Identity ID whose frozen tokens to destroy +- `frozenIdentityId` (text, required) - Identity ID whose frozen tokens to destroy - `publicNote` (text, optional) - Public Note Example: diff --git a/packages/wasm-sdk/api-definitions.json b/packages/wasm-sdk/api-definitions.json index bac7fa53fe..0953ed5407 100644 --- a/packages/wasm-sdk/api-definitions.json +++ b/packages/wasm-sdk/api-definitions.json @@ -1875,12 +1875,6 @@ "type": "text", "label": "Total Agreed Price (in credits) - Optional, fetches from pricing schedule if not provided", "required": false - }, - { - "name": "keyId", - "type": "number", - "label": "Key ID (for signing)", - "required": true } ] }, diff --git a/packages/wasm-sdk/docs.html b/packages/wasm-sdk/docs.html index ed15f0376e..d2a533b941 100644 --- a/packages/wasm-sdk/docs.html +++ b/packages/wasm-sdk/docs.html @@ -2639,11 +2639,6 @@
Parameters:
text (optional) -
- Key ID (for signing) - number - (required) -
diff --git a/packages/wasm-sdk/docs_manifest.json b/packages/wasm-sdk/docs_manifest.json index d117fc6660..80368c557e 100644 --- a/packages/wasm-sdk/docs_manifest.json +++ b/packages/wasm-sdk/docs_manifest.json @@ -1,5 +1,5 @@ { - "generated_at": "2025-09-02T17:31:30.731295+00:00", + "generated_at": "2025-09-03T20:55:56.075308+00:00", "queries": { "getIdentity": { "category": "identity", diff --git a/packages/wasm-sdk/test/ui-automation/fixtures/test-data.js b/packages/wasm-sdk/test/ui-automation/fixtures/test-data.js index 11c228de0b..1ac5ee6c06 100644 --- a/packages/wasm-sdk/test/ui-automation/fixtures/test-data.js +++ b/packages/wasm-sdk/test/ui-automation/fixtures/test-data.js @@ -772,7 +772,6 @@ const testData = { tokenPosition: 0, amount: "1", totalAgreedPrice: "10", - keyId: 0, description: "Direct purchase of tokens at configured price" } ]