refactor(sdk,wallet-lib,test-suite)!: convert dapi-client + wallet-lib + js-dash-sdk + platform-test-suite to ESM

[PastaPastaPasta]

Summary

Final PR in the ESM migration stack. Converts @dashevo/dapi-client, @dashevo/wallet-lib, dash (@dashevo/js-dash-sdk), and @dashevo/platform-test-suite to pure ESM. Removes the webpack/karma browser-bundle infrastructure across all four packages.

This is PR 3 of 3 (after the originally-stacked PRs 3/4/5 were merged into one — see note below). Depends on #3679 (cleanup) and #3680 (Uint8Array).

Note

Originally split into three stacked PRs (#3681 dapi-client, #3682 wallet-lib, #3683 js-dash-sdk+PTS), each on a separate branch. CI fails on any of them in isolation because the monorepo build compiles every package on every PR, and dapi-client-ESM + wallet-lib-CJS is an incompatible mid-state (CJS cannot require() ESM). Since they must land together regardless, they are combined here as a single PR with three commits preserved for review focus.

What changes

@dashevo/dapi-client (commit 1: refactor(dapi-client)!: convert to ESM, drop webpack/karma)

• package.json: "type": "module", "exports": { ".": "./lib/index.js", "./lib/*": "./lib/*" }, drops main. The wildcard preserves deep-import paths.
• All ~115 source files and ~80 test files converted from CJS require/module.exports to ESM import/export. Relative imports include .js extension.
• events npm package moved devDeps → deps. Used for EventEmitter in DAPIClient, ReconnectableStream, BlockHeadersProvider. Works in both Node and browser bundlers.
• Deletes webpack.config.js, karma.conf.js, lib/test/karma/. Removes all browser-polyfill devDeps (buffer, crypto-browserify, os-browserify, path-browserify, process, stream-browserify, string_decoder, url, util, webpack, webpack-cli, karma-*, babel-*).
• .mocharc.yml uses require: for the ESM bootstrap with a defensive loadDpp.default ?? loadDpp unwrap.

@dashevo/wallet-lib (commit 2: refactor(wallet-lib)!: convert to ESM, consume ESM dapi-client)

• package.json: "type": "module", engines.node >= 18.18. Drops build:web, test:browsers*, prepublishOnly. Removes all browser-polyfill devDeps. Removes deps winston, node-inspect-extracted.
• All 350+ files in src/, fixtures/, and tests/ converted from CJS to ESM with .js extensions on relative imports.
• src/logger/index.js rewritten as a console-backed logger (matching dapi-client's pattern from PR 1).
• Deep imports of @dashevo/dapi-client updated to include .js extensions.
• Deletes webpack.config.js, karma/, src/test/karma/.
• .mocharc.yml uses require: for ESM bootstrap.

dash / @dashevo/js-dash-sdk (commit 3: refactor(js-dash-sdk,platform-test-suite)!: convert to ESM, consume ESM dapi-client and wallet-lib)

• package.json: "type": "module", exports map, engines.node >= 18.18. Drops unpkg/browser, test:browsers*. Removes karma-*, webpack, browser polyfills, ts-mock-imports (replaced with an injectable seam).
• tsconfig.build.json and tsconfig.json: module: nodenext, moduleResolution: nodenext, target: es2020.
• All 54 .ts files get .js extensions on relative imports (NodeNext requirement).
• Refactored src/SDK/Client/Platform/methods/names/register.ts to accept an injectable randomBytes parameter (replaces ts-mock-imports for the existing test seam).
• Replaced winston with console-backed logger.
• CJS-named-import fixes (import { X } from cjs-pkg → import pkg from cjs-pkg; const { X } = pkg;) for dashcore-lib, wasm-dpp, grpc-common, contract packages.
• Added parallel import type { X as XType }; type X = XType; aliases in 22 .ts files where destructured value names are also used in type positions (TS2440 workaround under NodeNext).
• Defensive (loadDpp.default ?? loadDpp)() unwrap in 4 sites.
• Deletes webpack.config.js, webpack.base.config.js, karma/.

@dashevo/platform-test-suite (also in commit 3)

• package.json: "type": "module", drops test:browsers, browser polyfills, karma-*.
• All ~35 .js files converted to ESM.
• lib/test/bootstrap.js rewritten as ESM with fileURLToPath-based __dirname.
• .mocharc.yml uses import: for ESM root hooks.

Test plan

• yarn workspace @dashevo/dapi-client run test:unit — 315 passing ✅
• yarn workspace @dashevo/wallet-lib run test:unit — 377 passing, 2 pending ✅
• yarn workspace dash run test:unit — 60 passing, 3 pre-existing pending ✅
• yarn workspace @dashevo/platform-test-suite run lint — ESM bootstrap loads ✅
• platform-test-suite e2e tests require live testnet credentials in .env (pre-existing constraint).

Breaking changes

• All four packages are ESM-only. Any require() of them no longer works.
• Deep imports require .js extensions.
• No prebuilt browser bundles. Consumers must use a modern bundler (Vite/esbuild/webpack 5).
• js-dash-sdk's Platform.names.register(...) gained an optional trailing randomBytes parameter. Existing callers unaffected.
• Drops winston, bs58, node-inspect-extracted from deps where unused.

Monorepo state after this lands

• @dashevo/dapi-client — ESM, Uint8Array API, browser-bundler-friendly
• @dashevo/wallet-lib — ESM
• dash — ESM TypeScript
• @dashevo/platform-test-suite — ESM
• @dashevo/dashmate — was already ESM, works as-is
• @dashevo/dapi-grpc — patched in PR 1 (chore(dapi): cleanup — drop unused deps, inline winston/fetch/promisify shims #3679); rest unchanged

Stack

• PR 1 — Cleanup
• PR 2 — Buffer → Uint8Array
• ➡️ PR 3 — Full ESM conversion (this PR; replaces refactor(dapi)!: convert dapi-client to ESM, drop webpack/karma #3681 refactor(wallet-lib)!: convert to ESM, consume ESM dapi-client #3682 refactor(sdk,test-suite)!: convert to ESM, consume ESM dapi-client and wallet-lib #3683)

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f22cd12e-45b7-4f93-ad9f-d68fc11be420

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/esm-3-esm-conversion

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

✅ DashSDKFFI.xcframework built for this PR.

• Workflow run: https://github.com/dashpay/platform/actions/runs/26132120590
• Artifacts: DashSDKFFI.xcframework (folder), DashSDKFFI.xcframework.zip, xc_checksum.txt

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "d3a03c5dce08347513332117f46aa8601083d05f64eaeb7f09bf9f4b62651ebf"
)

Xcode manual integration:

• Download 'DashSDKFFI.xcframework' artifact from the run link above.
• Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
• If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.