Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart: add values.schema.yaml and associated maint. scripts #429

Merged
merged 7 commits into from Sep 7, 2021

Conversation

consideRatio
Copy link
Collaborator

@consideRatio consideRatio commented Aug 25, 2021

Closes #418 by adding a values.schema.yaml file that can be used to generate values.schema.json and ship with the Helm chart for helm CLI integrated end user config validation.

I consider it a breaking change as users may have put configuration that doesn't belong here and now they will have an error thrown if they upgrade with such configuration.

@consideRatio consideRatio changed the title Helm chart: add values.schema.yaml and associated maint. scripts" Helm chart: add values.schema.yaml and associated maint. scripts Aug 25, 2021
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts here @consideRatio. Generally this looks great!

resources/helm/tools/generate-json-schema.py Show resolved Hide resolved
resources/helm/dask-gateway/values.yaml Show resolved Hide resolved
@consideRatio consideRatio mentioned this pull request Sep 1, 2021
@consideRatio
Copy link
Collaborator Author

Getting this merged would unblock me fixing some other details, such as #375 #378 that requires changes to values.yaml and the schema.

@martindurant
Copy link
Member

@jcrist @jacobtomlinson are you likely to have time to have a look here?

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the review feedback here @consideRatio. Let's get this in, we can always iterate if we need to.

@jacobtomlinson jacobtomlinson merged commit d2f93eb into dask:main Sep 7, 2021
@consideRatio consideRatio moved this from In progress to Done in Eriks focus board Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Helm chart: Package a values.schema.json file with the chart to provide end user config validation logic
4 participants