Helm chart: add values.schema.yaml and associated maint. scripts #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
Member
jacobtomlinson
left a comment
jacobtomlinson
left a comment
There was a problem hiding this comment.
Thanks for the efforts here @consideRatio. Generally this looks great!
consideRatio
force-pushed
the
pr/add-values.schema.yaml
branch
from
f599676 to
76bf9f9
Compare
consideRatio
force-pushed
the
pr/add-values.schema.yaml
branch
from
bd6a69b to
e2fa139
Compare
Closed
Collaborator
Author
Member
|
@jcrist @jacobtomlinson are you likely to have time to have a look here? |
jacobtomlinson
approved these changes
Sep 7, 2021
Member
jacobtomlinson
left a comment
jacobtomlinson
left a comment
There was a problem hiding this comment.
Thanks for addressing the review feedback here @consideRatio. Let's get this in, we can always iterate if we need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #418 by adding a values.schema.yaml file that can be used to generate values.schema.json and ship with the Helm chart for
helmCLI integrated end user config validation.I consider it a breaking change as users may have put configuration that doesn't belong here and now they will have an error thrown if they upgrade with such configuration.