-
Notifications
You must be signed in to change notification settings - Fork 92
Added release notes #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added release notes #467
Conversation
|
Oh can we make it 1.0.0 instead? It helps communicate changes with semver. We had a alot of jupyterhub projects become 1.0.0 for this reason and it has been great - it becomes clear how to bump versions etc instead of unclear, for maintainers and users. For something like this, i suggest not using calver, but i dont know. |
|
I'd actually rather use calver to match the other dask release conventions. dask-gateway isn't really released on a clear schedule, and the default images are just a snapshot of whatever dask/distributed/etc... releases were latest at that time. Calver seems like the right fit to me. |
|
Calver / semver both seem like great improvements from using 0.x.y as we can communicate so little with 0.x.y. A big +1 for just going with one of calver / semver right now rather than sticking with 0.x.y. Note that the helm chart version cant have leading zeroes like 20.04 in ubuntu, because it must be semver2 compliant in format according to helm3 |
|
@TomAugspurger , dd you want to update this to use calver? |
|
Fine by me. Is there a target date set, or do you want to set the date and version at https://github.com/dask/dask-gateway/pull/467/files#diff-ef86237172bb2f91c585e845b38d6fb28bb6ac128ff8efa541cdd86f81751bf2R4 and merge this in just prior to releasing? |
|
It would be really nice to do it this month. There would be no need in the changelog, then, to specify the exact release date if it's already in the version. |
|
Thanks for driving this onwards @martindurant and @TomAugspurger! What CalVer format is proposed? Beware of
|
|
In dask we are using YYYY.MM.X where X is 0, 1, 2 for as many releases as happen in a month. We will always be .0 :) |
|
@martindurant with |
|
That's true, but pip tools strip the 0 anyway. If helm has a problem with it, .2. is fine too. This is for user interpretation mostly, and will still work with split-and-int either way. |
|
@martindurant okay so in this project - do we consistently go for YYYY.M.X format for the projects artifacts? We have the following artifacts influenced I think.
|
|
Yes, that's OK with me. Perhaps let the other people on this thread have a say until end of today. |
|
I suppose I forgot - still good to merge here? |
|
Merge and iterate sounds great to me. I sidetracked a bit on a versioning discussion but it is my understanding that we are to go for a YYYY.M.X release for all of our release artifacts, which would be the Python packages, Helm chart and associated docker images. |
|
+1 , we'll update the final version string when we have release credentials. |
I chose to name make this version
0.10.0. Dunno if we want to move to date-based versioning like the other Dask projects.