-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix ci failure, optimize workflow triggers, document use of pre-commit.ci #477
ci: fix ci failure, optimize workflow triggers, document use of pre-commit.ci #477
Conversation
branches-ignore: | ||
- "dependabot/**" | ||
- "pre-commit-ci-update-config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit.ci / dependabot pushes to these branches and opens a PR. So like this one would avoid triggering two workflow executions - one for the pushed branch, one for the PR.
3fc13c0
to
8b85092
Compare
I do like normalising how things are done, and of course fast failures - all without worrying about upstream checker versions. Does this add any extra effort when developing locally? |
Using pre-commit.ci would remove one piece of extra effort of developing locally and submitting a PR, which is to install and run Whats critical and should be fixed no matter what, is that we now have a |
I see what you mean :)
|
3107284
to
1c7b8ec
Compare
Test failures here are unrelated. Merging. |
Ignore this PR until having considered #476!
If there is agreement on using the pre-commit.ci service as motivated within #476, then this PR closes #476.