-
Notifications
You must be signed in to change notification settings - Fork 93
Helm chart: update traefik CRDs and Traefik version from 2.5 to 2.6 #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just confirming that the bundled CRDs won't interfere if I have an AKS cluster with |
e2d7945 to
e08c46e
Compare
|
@martindurant I'm not sure about the PBS failure's root cause - but I'm quite confident it's unrelated. I opened this issue about it: #422 @dhirschfeld the dask-gateway helm chart does indeed install some CRDs, and I'm not sure how For details on how
In practice, this means that a fresh install of dask-gateway will provide fresh CRDs, and if you upgrade after this has been made - I believe nothing will change in practice: the old CRDs will be used. This could be a problem that needs to be managed by communicating to the end users that the dask-gateway helm chart relies on modern traefik CRDs for its modern traefik version - and because of that, will need to manually delete the traefik CRDs and re-run a A discussion about this in depth is probably not relevant for the scope of this PR though - I suggest opening an issue if you want to deliberate on it further. So far, we haven't had problems with this. I've rebased this on the main branch that includes some CI fixes, hopefully the PBS test doesn't intermittently crash on us again. |
|
Thanks for the info @consideRatio! I imagine if you were trying to run two very different versions there might be some issues but I'm using close-to-the-latest version and I don't think the CRDs change too much so it should be fine. Something to keep in mind and if I ever do run into problems I can open an issue with a concrete example. |
|
I can confirm that the updated traefik and CRDs work fine (and with latest dask too) |
|
As a follow up, we might consider documentation about which versions of what we support; for example, the new CRD versions backport for a while, but how long? I suspect finding exact version bounds on things may be quite an involved process. |
|
@martindurant yeah it's tricky, especially since the versions of the CRDs are not really changed - they modify an existing version of the k8s resource they call v1alpha1. I think what we should do, is to realize via helm chart upgrade test, if a change will break an existing installation when upgrading. Then, if we conclude that it did - then we can make a decision on if we can/should do something to be backward compatible. I'm quite lost in general on the issues until they are demonstrated practically - so having an upgrade test of a helm chart installation seems like step 1. I opened #480 to reflect that need. Thanks @martindurant and @dhirschfeld for your review efforts! |
The Helm chart relies on Traefik, and Traefik relies on some CRDs be pre-installed, so we bundle those with the dask-gateway helm chart. This installation updates those bundled CRDs and the referenced Traefik version along with them.