ci: misc updates to test workflow and pytest-asyncio #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
consideRatio
commented
Mar 20, 2022
consideRatio
commented
- ci: test workflow, readability refactoring
- ci: test workflow, update versions
- ci: try unpin pytest-asyncio
- ci: asyncio_mode=auto makes us not need to decorate async tests
consideRatio
force-pushed
the
pr/3-refresh-test-workflow
branch
from
5a2ffff
to
d96a045
Compare
consideRatio
commented
Mar 20, 2022
| name: "Create k3d Cluster" | ||
| with: | ||
| cluster-name: "k3s-default" | ||
| args: >- | ||
| -p "30200:30200@agent[0]" | ||
| --port "30200:30200@agent:0:direct" |
There was a problem hiding this comment.
This related to breaking changes in bumping the k3d action, which now used k3d v5 instead of k3d v4.
25 tasks
jacobtomlinson
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
This looks great thanks @consideRatio. We should probably think about setting pytest-asyncio to auto in other projects too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.