Skip to content

Conversation

@consideRatio
Copy link
Collaborator

@consideRatio consideRatio commented Mar 20, 2022

This workflow is meant to help us with automation to publish to PyPI. It won't work without configured github secrets within this repo for the PyPI project's dask-gateway and dask-gateway-server. For that, we would need to take the steps outlined in #484 which I copy paste here:

@consideRatio consideRatio force-pushed the pr/build-publish-python-packages-workflow branch from 6a01e38 to 04efe06 Compare March 20, 2022 14:39
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I'll leave this until we get unblocked on the credentials.

@jcrist
Copy link
Member

jcrist commented Mar 24, 2022

Thanks Jacob and Erik, what are y'all's pypi usernames? I'll add you right now.

@martindurant
Copy link
Member

@jcrist , that's great news. Please also update the conda-forge feedstock.

@jacobtomlinson
Copy link
Member

Awesome thanks @jcrist. I am jacob.tomlinson and Erik is consideRatio. If you could merge conda-forge/dask-gateway-feedstock#22 also that would be great!

@jacobtomlinson
Copy link
Member

Thanks for updating PyPI @jcrist. I've added @martindurant too.

@jcrist
Copy link
Member

jcrist commented Mar 24, 2022

I'm not sure what your wheel building automation plans are, but note that dask-gateway-server has some native (go) code that will need to be fixed and checked by auditwheel. Previously I had a hacky buildscript I'd run locally for the osx & linux builds, but if I were to redo this today I'd just use cibuildwheel and be done with it. Apologies if y'all already know all this.

@jacobtomlinson jacobtomlinson merged commit 80a7f69 into dask:main Mar 24, 2022
@consideRatio
Copy link
Collaborator Author

consideRatio commented Mar 24, 2022

@jcrist thank you for clarifying this and suggesting a strategy to go about it, and thank you for your trust!

I have much to learn about Go but this seems like a good reason to learn some more. I'll rework this GitHub workflow as needed to make things work as they should.

Jim Is the hacky buildscript you had version controlled in this repo or something you could share in a gist or similar?

@jcrist
Copy link
Member

jcrist commented Mar 24, 2022

The scripts are here: https://github.com/dask/dask-gateway/tree/main/dask-gateway-server/build_tools, but things should build fine with cibuildwheel, provided the golang compiler is added to the build images before running the setup.py. This could be done with https://cibuildwheel.readthedocs.io/en/stable/options/#before-all perhaps. Note that dask-gateway-server doesn't support windows, so a bash script for linux/osx should be sufficient.

@consideRatio
Copy link
Collaborator Author

Ah excellent, I'm confident I can come up with something sensible with this very helpful guidance!

I opened #496 to track the need to fix this properly, something I'd be happy to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants