-
Notifications
You must be signed in to change notification settings - Fork 92
ci: build/push python packages workflow, added #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: build/push python packages workflow, added #494
Conversation
6a01e38 to
04efe06
Compare
jacobtomlinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I'll leave this until we get unblocked on the credentials.
|
Thanks Jacob and Erik, what are y'all's pypi usernames? I'll add you right now. |
|
@jcrist , that's great news. Please also update the conda-forge feedstock. |
|
Awesome thanks @jcrist. I am |
|
Thanks for updating PyPI @jcrist. I've added @martindurant too. |
|
I'm not sure what your wheel building automation plans are, but note that dask-gateway-server has some native (go) code that will need to be fixed and checked by auditwheel. Previously I had a hacky buildscript I'd run locally for the osx & linux builds, but if I were to redo this today I'd just use cibuildwheel and be done with it. Apologies if y'all already know all this. |
|
@jcrist thank you for clarifying this and suggesting a strategy to go about it, and thank you for your trust! I have much to learn about Go but this seems like a good reason to learn some more. I'll rework this GitHub workflow as needed to make things work as they should. Jim Is the hacky buildscript you had version controlled in this repo or something you could share in a gist or similar? |
|
The scripts are here: https://github.com/dask/dask-gateway/tree/main/dask-gateway-server/build_tools, but things should build fine with cibuildwheel, provided the golang compiler is added to the build images before running the setup.py. This could be done with https://cibuildwheel.readthedocs.io/en/stable/options/#before-all perhaps. Note that |
|
Ah excellent, I'm confident I can come up with something sensible with this very helpful guidance! I opened #496 to track the need to fix this properly, something I'd be happy to do. |
This workflow is meant to help us with automation to publish to PyPI. It won't work without configured github secrets within this repo for the PyPI project's dask-gateway and dask-gateway-server. For that, we would need to take the steps outlined in #484 which I copy paste here:
We need deployment keys for both PyPI projects available to this repo's GitHub workflows (dask-gateway, dask-gateway-server). This can only be done by a PyPI project maintainer, currently that must be @jcrist.
pypi_token__dask_gatewayandpypi_token__dask_gateway_server.It would be good to have an additional owner from the Dask team added to those PyPI projects.