Remove legacy purge flag from k8s uninstall docs#502
Merged
consideRatio merged 1 commit intodask:mainfrom Mar 26, 2022
brews:helm_doc_fix
Merged
Remove legacy purge flag from k8s uninstall docs#502consideRatio merged 1 commit intodask:mainfrom brews:helm_doc_fix
consideRatio merged 1 commit intodask:mainfrom
brews:helm_doc_fix
Conversation
Minor doc fix! The [install instructions for dask-gateway on Kubernetes](https://gateway.dask.org/install-kube.html#shutting-everything-down) use an unsupported flag (`--purge`) in the `helm` command for cleanup and uninstalling work. When run, this throws an error at the poor user. This PR updates the docs to remove the `--purge` flag. The behavior from `--purge` is the default behavior in the current version of `helm`.
consideRatio
approved these changes
Mar 26, 2022
Collaborator
|
Thank yo @brews!! |
consideRatio
added a commit
that referenced
this pull request
Mar 26, 2022
* adding conda env file with dev dependencies * adding conda env create instructions * adding kubectl and helm * adding comments for where dependencies are defined * adding comments where dependencies are defined * updating description in development docs * adding minikube to local dev (kubernetes) dependencies * unpinning pytest-asyncio and adding inline comment in src files indicating that files must be kept in sync * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Remove legacy purge flag from k8s uninstall docs (#502) Minor doc fix! The [install instructions for dask-gateway on Kubernetes](https://gateway.dask.org/install-kube.html#shutting-everything-down) use an unsupported flag (`--purge`) in the `helm` command for cleanup and uninstalling work. When run, this throws an error at the poor user. This PR updates the docs to remove the `--purge` flag. The behavior from `--purge` is the default behavior in the current version of `helm`. * maint/ci: remove support for Python 3.6 and test against multiple versions of Python and Golang (#501) * ci: test against multiple versions of Python and Golang * Require Python 3.7+ and only test against it and higher * adding conda env file with dev dependencies * adding conda env create instructions * adding kubectl and helm * adding comments for where dependencies are defined * adding comments where dependencies are defined * updating description in development docs * adding minikube to local dev (kubernetes) dependencies * unpinning pytest-asyncio and adding inline comment in src files indicating that files must be kept in sync * updating docs/source/develop.rst with new environment filename * updating to python=3.10 * updating dask-gateway, dask-gateway-server, and docs dependencies blocks with inline comments * updating CI and tests dependencies block * updating pip dependencies block with autotoc-traits * fixing title underline from docs workflow warning * fixing kubernetes-asyncio to kubernetes_asyncio from feedstock name * Apply suggestions from code review Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Brewster Malevich <sbmalev@gmail.com> Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor doc fix!
The install instructions for dask-gateway on Kubernetes use an unsupported flag (
--purge) in thehelmcommand for cleanup and uninstalling work. When run, this throws an error at the poor user.This updates the docs to remove the
--purgeflag. No other change is needed because behavior from--purgeis the default behavior in the current version ofhelm.