ci: run go native tests against modern versions of go #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Thank you @jcrist for review/merge!! |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't understand enough about go to successfully run the go native tests defined in dask-gateway-server/dask-gateway-proxy against versions 1.16+. I've now pieced together some additional understanding to get this to work. I think the gist was that we had to install golang test dependencies part of the project, and not globally for Go 1.16+.
This could perhaps be worked around by having a global environment variable GO111MODULE=auto, or setup the test dependencies in another way somehow? I'm not sure. For now, this change to run
go getfrom the folder with the golang code seems like a good resolution that seem to work for many versions of golang.