maint: avoid regression/breaking change in click and declare our dependency to the library explicitly#525
Merged
consideRatio merged 1 commit intodask:mainfrom Apr 6, 2022
Conversation
consideRatio
force-pushed
the
pr/avoid-click-regression
branch
from
c90268c to
e522f83
Compare
consideRatio
changed the title
consideRatio
changed the title
click and declare our dependency to the library explicitly
consideRatio
changed the title
click and declare our dependency to the library explicitlyclick and declare our dependency to the library explicitly
consideRatio
force-pushed
the
pr/avoid-click-regression
branch
from
e522f83 to
e5415df
Compare
Collaborator
Author
|
Aaarrgh, I have to pin click in four separate places!!! I think its absolutely critical that we de-duplicate the dependencies we list for maintenance to be sustainable. I'll go for a self-merge on this so I can rebase #519 and avoid this added complexity to that PR. |
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dask-gateway was dependent on click, but we didn't declare that dependency explicitly but instead relied on it showing up as a dependency from something else we had installed. Since we have a direct
import clickstatement in the dask-gateway project, I suggest it is listed explicitly as a dependency like done in this PR now.As part of listing
clickas an explicit dependency, we also pin it to avoid 8.1.0-8.1.2 which breaks things for us as discussed in #522.