Reference distributed's actual TimeoutError used #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/remove-tornado-dependency-for-dask-gateway-server
branch
from
2bdc369 to
a0c4579
Compare
This was referenced Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #515 by relying on a change in dask/distributed#3394 which is released and part of distributed 2021.01.21.
By referencing the TimeoutError as defined by the distributed package, we don't have to install tornado as part of dask-gateway-server any more.
Note that this will have various merge conflicts with other PRs i have open. Prefer if those are merged before this to make me fix the conflicts in this PR instead of those.
EDIT: Going for a self-merge of this now and rebasing the others for cleaner merge of those that may merit more review and agreement.