Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci, maint: build/publish to PyPI, build linux/mac and amd64/arm64 wheels #538

Merged
merged 7 commits into from
Apr 19, 2022

Conversation

consideRatio
Copy link
Collaborator

@consideRatio consideRatio commented Apr 18, 2022

Summary

  • We now have automation to publish packaged source distributions and wheels to PyPI.
  • We provide four platform dependent wheels for dask-gateway-server for linux and mac that comes in amd64 and arm64 variants.
  • Various refactoring is done and documentation is improved to reduce complexity and improve long term maintenance.
  • This workflow was developed against PyPI's test server, see https://test.pypi.org/project/dask-gateway-server/0.9.0/#files for the result.

Noteworthy details

  • dask-gateway-server/build_tools are removed as most relevant logic moved to dask-gateway-server/setup.py and the remaining logic to set GOOS and GOARCH Golang cross compilation environment variables made sense to do in the GitHub Workflow without having a dedicated script for.
  • dask-gateway-server's --no-build-proxy flag in setup.py is replaced with an environment variable DASK_GATEWAY_SERVER__NO_PROXY. Retaining the flag forced many not-robust workarounds. The environment variable also helps us ensure we don't package a binary in wheels we build.

Closes #537

@consideRatio consideRatio changed the title ci: fix automated builds to publish to PyPI ci: fix automated builds to publish to PyPI, and support linux/mac and amd64/arm64 wheels for dask-gateway-server Apr 18, 2022
@consideRatio consideRatio changed the title ci: fix automated builds to publish to PyPI, and support linux/mac and amd64/arm64 wheels for dask-gateway-server ci, maint: build/publish to PyPI, build linux/mac and amd64/arm64 wheels Apr 18, 2022
@consideRatio consideRatio marked this pull request as draft April 18, 2022 17:21
@consideRatio consideRatio marked this pull request as ready for review April 18, 2022 17:48
@consideRatio
Copy link
Collaborator Author

consideRatio commented Apr 19, 2022

I'll go for a merge and trial a pre-release to verify functionality of the CI system and if it succeeds, follow up with tests against the release end-to-end in a real world installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant