Fix failure to start api/controller pods with tini as an entrypoint#540
Merged
consideRatio merged 1 commit intoApr 19, 2022
Merged
Conversation
This was referenced Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENTRYPOINTin a Dockerfile maps tocommandin a k8s Pod specification, andCMDin a Dockerfile maps toargsin a k8s Pod specification. By definingargsinstead ofcommand, we override the image'sCMDbut not itsENTRYPOINTand like that we end up successfully usingtinias an entrypoint.This change relates to this Dockerfile, that has a
ENTRYPOINTakacommandset to usetini.dask-gateway/dask-gateway-server/Dockerfile
Lines 44 to 45 in fd2ada0