Skip to content

Fix failure to start api/controller pods with tini as an entrypoint#540

Merged
consideRatio merged 1 commit into
dask:mainfrom
consideRatio:pr/fix-entrypoints-for-images
Apr 19, 2022
Merged

Fix failure to start api/controller pods with tini as an entrypoint#540
consideRatio merged 1 commit into
dask:mainfrom
consideRatio:pr/fix-entrypoints-for-images

Conversation

@consideRatio

@consideRatio consideRatio commented Apr 18, 2022

Copy link
Copy Markdown
Collaborator

ENTRYPOINT in a Dockerfile maps to command in a k8s Pod specification, and CMD in a Dockerfile maps to args in a k8s Pod specification. By defining args instead of command, we override the image's CMD but not its ENTRYPOINT and like that we end up successfully using tini as an entrypoint.

This change relates to this Dockerfile, that has a ENTRYPOINT aka command set to use tini.

ENTRYPOINT ["tini", "-g", "--"]
CMD ["dask-gateway-server", "--config", "/etc/dask-gateway/dask_gateway_config.py"]

@consideRatio consideRatio requested a review from jcrist April 18, 2022 22:13
@consideRatio consideRatio added the bug Something isn't working label Apr 18, 2022
@consideRatio consideRatio merged commit 70d502c into dask:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant