ci: avoid running tests in fork's PR branches#541
Merged
consideRatio merged 1 commit intodask:mainfrom Apr 18, 2022
Merged
Conversation
If tests are run in a fork, they will fail, as they don't have access to the private testing images. When that fail happen, it will be seen as a red cross on the commit even before the pull_request triggered tests has completed. Like this, we save some compute by not running things twice and we avoid test failure notifications etc.
Collaborator
Author
|
Thanks Jim! |
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If tests are run in a fork, they will fail, as they don't have access to the semi-private testing images. When that fail happen, it will be seen as a red cross on the commit even before the pull_request triggered tests has completed. Like this, we save some compute by not running things twice and we avoid test failure notifications etc.
About semi-private images
The
ghcr.io/dask/dask-gateway-ci-hadoopimage and otherghcr.io/dask/dask-gateway-ci-images are marked as private, but we have also made them available to PRs in this repo. So, they are private to not draw attention rather than being secret.Screenshots from errors we avoid with this PR