Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: avoid running tests in fork's PR branches #541

Merged

Conversation

consideRatio
Copy link
Collaborator

@consideRatio consideRatio commented Apr 18, 2022

If tests are run in a fork, they will fail, as they don't have access to the semi-private testing images. When that fail happen, it will be seen as a red cross on the commit even before the pull_request triggered tests has completed. Like this, we save some compute by not running things twice and we avoid test failure notifications etc.

About semi-private images

The ghcr.io/dask/dask-gateway-ci-hadoop image and other ghcr.io/dask/dask-gateway-ci- images are marked as private, but we have also made them available to PRs in this repo. So, they are private to not draw attention rather than being secret.

Screenshots from errors we avoid with this PR

image

image

image

If tests are run in a fork, they will fail, as they don't have access to
the private testing images. When that fail happen, it will be seen as a
red cross on the commit even before the pull_request triggered tests has
completed. Like this, we save some compute by not running things twice
and we avoid test failure notifications etc.
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Erik!

@consideRatio consideRatio merged commit fd2ada0 into dask:main Apr 18, 2022
@consideRatio
Copy link
Collaborator Author

Thanks Jim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants