Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev-environment.yaml and remove #550



Copy link

@consideRatio consideRatio commented Apr 20, 2022

I wanted to avoid the duplication of python dependencies, and dev-environment.yaml was the last place there was duplication.

I'm also opining to remove the built in helm lint and helm install --dry-run tests that can run locally for a combination of reasons.

  • I ran into errors running them locally because of they require that you don't have various credentials helpers for working with a k8s cluster, and that your default kubernetes config isn't causing trouble etc.
  • It requires helm and makes us need to install it for a local dev setup.
  • It is already tested in github workflows testing the helm chart more thoroughly

Closes #546.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Proposal to remove/rework dev-environment.yml?
1 participant