ci: add helm chart upgrade test - #551
Merged
consideRatio merged 1 commit intoApr 21, 2022
Merged
Conversation
consideRatio
force-pushed
the
pr/add-helm-chart-upgrade-test
branch
from
April 20, 2022 22:04
ecee866 to
b23cb3a
Compare
12 tasks
consideRatio
force-pushed
the
pr/add-helm-chart-upgrade-test
branch
from
April 21, 2022 09:35
594a36b to
925ad0d
Compare
consideRatio
marked this pull request as draft
April 21, 2022 09:35
consideRatio
force-pushed
the
pr/add-helm-chart-upgrade-test
branch
2 times, most recently
from
April 21, 2022 12:12
340c9d7 to
9118173
Compare
consideRatio
marked this pull request as ready for review
April 21, 2022 12:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #480. Seems relevant to have a test to test the upgrade of the Helm chart from some previous version as by doing so we help verify we won't have trouble when we make a new release and people will upgrade.
This test already caught that we need to ask users to do a manual
kubectl applyof the bundled CRDs, see #553.