-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golang: refresh dask-gateway-proxy using modules and package directories #559
golang: refresh dask-gateway-proxy using modules and package directories #559
Conversation
…-proxy Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this @rigzba21!!! From what I can tell, this looks good. I left a few comments for my own insight but this LGTM from what I can tell.
Also note that the test failures are unrelated at least to this PR (ipython/traitlets#731).
dask-gateway-server/dask-gateway-proxy/cmd/dask-gateway-proxy/main.go
Outdated
Show resolved
Hide resolved
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
@martindurant @TomAugspurger @jacobtomlinson a ping for review, i figure we merge this soonish without further comments. |
I've never written go before, but +1 to the goals of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a great move to me. The only comment I have is why are we putting some code under pkg
? I don't think we should be intentionally exposing any public APIs and we should probably place it in internal
instead.
I thought about that, however, I figured that might be a design decision outside of the scope of this PR, and might fit better in a separate PR, and I do not have as much context into the long-term goals for dask-gateway-proxy. |
Deal! Let's go for a merge on this. The tests were passing before we ran into an issue I think was related to traitlets (ipython/traitlets#731). |
@rigzba21 thank you so much for your work on this!!!!!! 🎉 ❤️ 🌻 |
@consideRatio Restructuring dask-gateway-proxy using go project layout to address #506
Nothing has changed as far as functionality.
router.go
andsni.go
have been moved into separate packages under thepkg/
directory.main.go
has been moved tocmd/dask-gateway-proxy
.logging.go
has been moved to its own internal package underinternal/logging
.go.mod
andgo.sum
with dependencies.pkg/
,cmd/dask-gateway-proxy/
, andinternal/
.pkg/router
.I hope this helps!
EDIT: closes #506!