Provide frozen requirements.txt files for images, and automation to update them - #575
Merged
consideRatio merged 1 commit intoJun 13, 2022
Conversation
consideRatio
force-pushed
the
pr/use-frozen-requirements.txt-for-images
branch
from
June 10, 2022 23:00
45bf862 to
b4a9784
Compare
consideRatio
requested review from
TomAugspurger,
jacobtomlinson and
martindurant
June 10, 2022 23:17
consideRatio
force-pushed
the
pr/use-frozen-requirements.txt-for-images
branch
2 times, most recently
from
June 11, 2022 09:10
4dcddcd to
a7aa9af
Compare
Closed
consideRatio
force-pushed
the
pr/use-frozen-requirements.txt-for-images
branch
from
June 11, 2022 15:56
a7aa9af to
39a1f77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes our Dockerfiles build from frozen Dockerfile.requirements.txt files to provide a git history of what is installed in the images. It also adds a github workflow to automatically refreeze the requirements.txt file with the click of a button.
I'm not sure if adding this complexity is worth the benefits, but if it isn't the work I've invested in this PR is something I can benefit on in other projects where its more critical to have a version controlled history of whats part of images.
Pros
Cons
PR tested to work in a fork. Test failures are unrelated and fixed by #573.