Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide frozen requirements.txt files for images, and automation to update them #575

Merged

Conversation

consideRatio
Copy link
Collaborator

@consideRatio consideRatio commented Jun 10, 2022

This PR makes our Dockerfiles build from frozen Dockerfile.requirements.txt files to provide a git history of what is installed in the images. It also adds a github workflow to automatically refreeze the requirements.txt file with the click of a button.

I'm not sure if adding this complexity is worth the benefits, but if it isn't the work I've invested in this PR is something I can benefit on in other projects where its more critical to have a version controlled history of whats part of images.

Pros

Cons

  • Helm chart tests will be based on frozen dependencies
  • Even with automation in place to refreeze, its still work added.
  • The automation could need maintenance
  • The entire setup adds complexity for people looking to understand how things work

PR tested to work in a fork. Test failures are unrelated and fixed by #573.

@consideRatio consideRatio force-pushed the pr/use-frozen-requirements.txt-for-images branch from 45bf862 to b4a9784 Compare June 10, 2022 23:00
@consideRatio consideRatio force-pushed the pr/use-frozen-requirements.txt-for-images branch 2 times, most recently from 4dcddcd to a7aa9af Compare June 11, 2022 09:10
@consideRatio consideRatio mentioned this pull request Jun 11, 2022
@consideRatio consideRatio added the enhancement New feature or request label Jun 11, 2022
@consideRatio consideRatio changed the title Provide frozen requirements.txt files for images, and automation Provide frozen requirements.txt files for images, and automation to update them Jun 11, 2022
@consideRatio consideRatio force-pushed the pr/use-frozen-requirements.txt-for-images branch from a7aa9af to 39a1f77 Compare June 11, 2022 15:56
@consideRatio consideRatio merged commit a9550f6 into dask:main Jun 13, 2022
@consideRatio consideRatio added new and removed enhancement New feature or request labels Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant