Reorder gateway config and update comment about gateway.nodeSelector #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
approved these changes
Jul 29, 2022
Collaborator
consideRatio
left a comment
consideRatio
left a comment
There was a problem hiding this comment.
Thanks @GeorgianaElena! This has confused me as well!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
gateway.backendentry, otherwise the bigbackendconfig description makes it hard to see that they belong to gateway config and are not part ofgateway.backend.gateway.nodeSelectorwill apply too.This actually caused me a bit of confusion, because I thought the
"gateway pods"were actually the backend worker and scheduler pods, but the selector actually got applied to theapipod too (reference)