Skip to content

Conversation

@maxime1907
Copy link
Contributor

Fixes the missing fields in schema and values that are present in _helpers.tpl:

  • fullnameOverride
  • nameOverride

@maxime1907
Copy link
Contributor Author

cc @consideRatio

@consideRatio
Copy link
Collaborator

Can you verify that the functionality described matches the behavior in this helm chart? This is copy pasted from jupyterhub/jupyterhub and some notes are related to that still, and the behavior in that helm chart is not standard as there were adjustments made to avoid introducing breaking changes when adding support for fullnameOverride and nameOverride.

  • Validate documented claims
  • Remove text about user pods that clearly is unrelated and review the notes in general, they probably don't make sense.

Alternatively, omit the descriptions. What is clear is that the schema should include the entries allowing them to be set, so just adding schemas without description in the schema is an improvement. I just don't want anything added to be misleading.

@consideRatio consideRatio added the bug Something isn't working label Aug 11, 2022
@consideRatio consideRatio merged commit 69fee49 into dask:main Aug 11, 2022
@consideRatio
Copy link
Collaborator

Thanks @maxime1907!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants