refactor: use traefik documented syntax for cli flags #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seem to work no matter what, but when debugging things earlier it made me wonder if we had an issue passing these flags as their case didn't align with the documentation in traefik. This refactoring makes us align with the documented way of passing the flags.
consideRatio
requested review from
TomAugspurger,
jacobtomlinson and
martindurant
martindurant
approved these changes
Oct 11, 2022
Collaborator
Author
|
Thanks @martindurant! After a self-review delayed in time and your approval, I'll go for a merge here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a simple refactoring to use CLI flags for traefik that matches what they document they accept.
This seem to work no matter what, but when debugging things earlier it made me wonder if we had an issue passing these flags as their case didn't align with the documentation in traefik. This refactoring makes us align with the documented way of passing the flags.