Fix failure to build and publish arm64 images #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/trial-making-everything-arm64-compatible
branch
from
278fd11 to
e8161cf
Compare
consideRatio
changed the title
consideRatio
force-pushed
the
pr/trial-making-everything-arm64-compatible
branch
3 times, most recently
from
60dd631 to
4996798
Compare
consideRatio
changed the title
consideRatio
force-pushed
the
pr/trial-making-everything-arm64-compatible
branch
from
4996798 to
e96e3da
Compare
consideRatio
added
bug
consideRatio
force-pushed
the
pr/trial-making-everything-arm64-compatible
branch
from
e96e3da to
e4c9631
Compare
jacobtomlinson
approved these changes
Nov 7, 2022
| # Install dask-gateway | ||
| COPY --chown=dask:dask . /opt/dask-gateway | ||
| RUN pip install --no-cache-dir \ | ||
| ARG PIP_CACHE_DIR=/tmp/pip-cache |
Member
There was a problem hiding this comment.
Does this need to be set a second time?
Collaborator
Author
There was a problem hiding this comment.
Yepp, another stage, another built-time env var needed to configure pip where to store/read cache
Collaborator
Author
|
Going for a self-merge and a changelog for review/merge -> release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--mountfor theRUNcommand, making things from the previous stage accessible without creating another layer that takes up space in the final image.Background
There is a bug in
chartpressmaking us fail to build and publish the arm64 variant of the dask-gateway-server image. This PR makes us avoid that bug by making the dask-gateway image also support arm64.