Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: increase test's wait duration for shutdown of worker processes for distributed>=2022.11.0 #652

Merged

Conversation

consideRatio
Copy link
Collaborator

@consideRatio consideRatio commented Dec 13, 2022

Previously, apparently <1 second of wait was required to see distributed worker processes shut down. Now we seem to need need >2,<5, and I've made it 10 to be safe.

@consideRatio consideRatio force-pushed the pr/test-fix-distributed-2022.11.0 branch 2 times, most recently from eddf3f6 to ff9a189 Compare December 13, 2022 01:00
@consideRatio consideRatio changed the title maint: test changes to fix test failures maint: increase tests wait duration for worker shutdown following distributed>=2022.11.0 Dec 13, 2022
@consideRatio consideRatio marked this pull request as ready for review December 13, 2022 01:02
@consideRatio consideRatio force-pushed the pr/test-fix-distributed-2022.11.0 branch from ff9a189 to 2ef8cea Compare December 13, 2022 01:04
@consideRatio consideRatio changed the title maint: increase tests wait duration for worker shutdown following distributed>=2022.11.0 maint: increase test's wait duration for shutdown of worker processes for distributed>=2022.11.0 Dec 13, 2022
Apparently a longer duration to wait for scaling events, at least scale
down events, for a local cluster as of distributed>=2022.11.0.

Before, we could wait less than 1 second without issues, and now we need
to wait more than 2, and seemingly less than 5 seconds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression with distributed 2022.11.0 and 2022.11.1?
1 participant