maint: increase test's wait duration for shutdown of worker processes for distributed>=2022.11.0#652
Merged
consideRatio merged 1 commit intoDec 13, 2022
Conversation
consideRatio
force-pushed
the
pr/test-fix-distributed-2022.11.0
branch
2 times, most recently
from
eddf3f6 to
ff9a189
Compare
consideRatio
changed the title
consideRatio
force-pushed
the
pr/test-fix-distributed-2022.11.0
branch
from
ff9a189 to
2ef8cea
Compare
consideRatio
changed the title
Apparently a longer duration to wait for scaling events, at least scale down events, for a local cluster as of distributed>=2022.11.0. Before, we could wait less than 1 second without issues, and now we need to wait more than 2, and seemingly less than 5 seconds.
consideRatio
force-pushed
the
pr/test-fix-distributed-2022.11.0
branch
from
2ef8cea to
c654ba3
Compare
This was referenced Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, apparently <1 second of wait was required to see distributed worker processes shut down. Now we seem to need need
>2,<5, and I've made it 10 to be safe.