Skip to content

Support and require sqlalchemy 2.0 - #685

Merged
consideRatio merged 2 commits into
dask:mainfrom
TomAugspurger:tom/fix/sqlalchemy-2.0
Feb 15, 2023
Merged

consideRatio merged 2 commits into
dask:mainfrom
TomAugspurger:tom/fix/sqlalchemy-2.0

Conversation

@TomAugspurger

Copy link
Copy Markdown
Member

This adds compatibility for sqlalchemy 2.0. It also requires sqlalchemy 2.0. I didn't look deeply, but IMO we don't have the maintainer bandwidth to try to support both.

Closes #679

@consideRatio
consideRatio merged commit 5771a3f into dask:main Feb 15, 2023
@consideRatio consideRatio changed the title sqlalchemy 2.0 Support and require sqlalchemy 2.0 Feb 15, 2023
@consideRatio

consideRatio commented Feb 15, 2023 •

Copy link
Copy Markdown
Collaborator

@TomAugspurger wieeeee thank you!!!!!! ❤️ 🎉 🌻

I fully agree that adding support for both 1 and 2 isn't important enough to work giving our low maintainer bandwidth!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Develop support for sqlalchemy 2 in dask-gateway-server

2 participants