k8s controller: round to worker cores to three digits, not one #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/fix-rounding
branch
from
fe53ac8 to
c5b2248
Compare
consideRatio
added
bug
consideRatio
requested review from
TomAugspurger,
jacobtomlinson and
martindurant
TomAugspurger
approved these changes
Oct 31, 2023
|
Thank you @TomAugspurger!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that CPU requests as enforced by the container runtimes associated with k8s clusters often has a resolution to millicores or 0.001 of a core, so going for three decimals makes us not loose resolution without introducing loads of decimals.