Skip to content

helm-chart: remove deprecated use of traefik middleware's forceSlash option#853

Merged
consideRatio merged 1 commit intodask:mainfrom
gardleopard:traefik_remove_force_slash
Feb 3, 2025
Merged

helm-chart: remove deprecated use of traefik middleware's forceSlash option#853
consideRatio merged 1 commit intodask:mainfrom
gardleopard:traefik_remove_force_slash

Conversation

@gardleopard
Copy link
Copy Markdown
Contributor

forceSlash is deprecated by traefik.

I ran the tests on my github user and the k8s v1.32 tests passed. Ref https://github.com/gardleopard/dask-gateway/pull/1/checks . I guess pr #851 experienced flaky tests

closes #852

forceSlash is deprecated by traefik
@consideRatio
Copy link
Copy Markdown
Collaborator

I'm hesitant because I'm not fully confident we don't cause issues here.

I'll try to become confident...

  1. This change only impacts the helm-chart if gateway.prefix is not /
  2. The helm chart has a default value of /
    gateway:
      # Path prefix to serve dask-gateway api requests under
      # This prefix will be added to all routes the gateway manages
      # in the traefik proxy.
      prefix: /
  3. Our tests typically configure this:
    gateway:
      prefix: /services/dask-gateway
  4. The forceSlash option ensures the resulting stripped path is not the empty string, by replacing it with / when necessary.
    In other words, this is only meant to impact a situation if you'd configure gateway.prefix explicitly to be the empty string or null in the helm chart. Can this happen? Hmmm...

Let's go with it, I think it's probably ok. It's also not obvious if this option is defaulting to false or true even though it's documented to default to true, it seems that it may default to false in the code.

@consideRatio consideRatio changed the title chore(traefik): remove deprecated setting forceSlash helm-chart: remove deprecated use of traefik middleware's forceSlash option (#853) Feb 3, 2025
@consideRatio consideRatio changed the title helm-chart: remove deprecated use of traefik middleware's forceSlash option (#853) helm-chart: remove deprecated use of traefik middleware's forceSlash option Feb 3, 2025
@consideRatio consideRatio merged commit 4b9b1a0 into dask:main Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop using deprecated forceSlack in traefik middleware resources

2 participants