helm-chart: remove deprecated use of traefik middleware's forceSlash option#853
Merged
consideRatio merged 1 commit intodask:mainfrom Feb 3, 2025
Merged
Conversation
forceSlash is deprecated by traefik
Collaborator
|
I'm hesitant because I'm not fully confident we don't cause issues here. I'll try to become confident...
Let's go with it, I think it's probably ok. It's also not obvious if this option is defaulting to false or true even though it's documented to default to true, it seems that it may default to false in the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forceSlash is deprecated by traefik.
I ran the tests on my github user and the k8s v1.32 tests passed. Ref https://github.com/gardleopard/dask-gateway/pull/1/checks . I guess pr #851 experienced flaky tests
closes #852