Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
/api/user added in 0.8 in 2017 /authorizations/token deprecated since 2.0 in 2021
minrk
force-pushed
the
jupyterhub-auth
branch
from
432e4d5 to
05f05c4
Compare
consideRatio
approved these changes
Feb 3, 2025
Collaborator
consideRatio
left a comment
consideRatio
left a comment
There was a problem hiding this comment.
Thank you @minrk and welcome as a code contributor to dask-gateway! ❤️ 🎉
minrk
commented
Feb 3, 2025
| url = f"{self.jupyterhub_api_url}/user" | ||
|
|
||
| kwargs = { | ||
| "headers": {"Authorization": "token %s" % self.jupyterhub_api_token}, |
Contributor
Author
There was a problem hiding this comment.
Notably, jupyterhub_api_token is entirely not needed by JupyterHubAuth. With this implementation, dask-gateway technically doesn't need to be registered as a jupyterhub service, since it makes no use of the jupyterhub API as itself. That would only really be needed if the gateway began applying full oauth to protect dashboard pages, which appear to currently only be protected by the unguessable cluster names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use standard
/api/userinstead/authorizations/token/{token}is deprecated since jupyterhub 2.0 in 2021, superseded by/api/userin 0.8 in 2017.