Fix typo in SLURM backend.#883
Merged
Merged
Conversation
This typo prevents a cluster being created when a SLURM qos is set.
consideRatio
approved these changes
Feb 10, 2025
Collaborator
|
Thank you @amanning9!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This typo prevents a cluster being created when a SLURM qos is set.
Like #603 but for qos instead. This list needs to be appended to instead of extended.
Apologies for not noticing this when I did #603 - we've just started using qos-s and ran into this immediately!