Handle dask-worker command args and extra kwargs as a list

[guillaumeeb]

Fixes #156

[willirath]

Just a comment that is beyond the scope of this PR: Keeping track of all the CLI args to dask-worker in a list_of_all_args (see the recommended way of passing args to subprocess) and eventually do " ".join(list_of_all_args) would be a general way of solving this.

[guillaumeeb]

@willirath this would probably be cleaner yes, but should we change the extra constructor kwargs to be also a list then?

[willirath]

but should we change the extra constructor kwargs to be also a list then?

My personal feeling says: Yes, passing CLI args as a sequence is standard any way. But I'm not sure if that's representative.

[guillaumeeb]

Okay, so I chose to follow your suggestion @willirath.

[guillaumeeb]

Travis was also having a difficult monday apprently.

[guillaumeeb]

@willirath, since you've made the comment about using a list of args, a review would be welcome!

[willirath]

I think, the default config also has to be adapted:

dask-jobqueue/dask_jobqueue/jobqueue.yaml

Line 18 in 14c22b3

extra: ""

[willirath]

And the interface is stil set as a string:

dask-jobqueue/dask_jobqueue/core.py

Line 204 in 14c22b3

extra += ' --interface %s ' % interface

This should be

extra += [' --interface', interface]

Edit: Typo in second list item.

[guillaumeeb]

Few, thanks for that @willirath, no real testing from my part before your comments... Glad you saw those mistakes.

[willirath]

Looks good!

[guillaumeeb]

Thanks @willirath, feel free to take a look at other PR/issues if you find the time. It could be nice to have another core maintainer.

[willirath]

Thanks @willirath, feel free to take a look at other PR/issues if you find the time. It could be nice to have another core maintainer.

Sounds good. I'm not sure I'll have much time for continuous work. But it sure looks like dask clusters and dask-jobqueue will play a increasingly role in my and my group's routine work. So count me in!

[guillaumeeb]

Nice !

We're all on the same situation about time 🙂 !