Add ability to override python used to start workers#167
Conversation
| if env_extra is None: | ||
| env_extra = dask.config.get('jobqueue.%s.env-extra' % self.scheduler_name) | ||
| if python is None: | ||
| python = sys.executable |
There was a problem hiding this comment.
I think that we can safely include this directly in the signature. It's not going to change.
There was a problem hiding this comment.
So this means no config entry?
There was a problem hiding this comment.
Right. If we were to include this as part of the config (which I don't think is necessary) then we would want to check the default every time we called the constructor here, so we would need this check to be within the constuctor as you have it here. However if the default value is just going to be sys.executable (which I think is best today) then we can include it as a default directly in the signature of the constructor. This is a bit better both because it reduces code, and because it makes the default visible if people look at the docstring.
| cancel_command: str | ||
| Abstract attribute for job scheduler cancel command, | ||
| should be overriden | ||
| should be overridden |
There was a problem hiding this comment.
Thanks for correcting these typos
|
One small comment. Otherwise this looks good to me. Thanks @ocaisa |
3 participants
fixes #166