Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a `job_extra` flag to the SGECluster #256

Merged
merged 4 commits into from Apr 5, 2019

Conversation

@Lnaden
Copy link
Contributor

Lnaden commented Mar 22, 2019

The SGECluster has no job_extra setting like all the other clusters do, which limits its abilities. This PR adds the job_extra flag in the same way as it appears in the other cluster files.

xref #219 and #235 which seemed to allude to SGECluster having the job_extra flag, but no such flag appears to exist.

Lnaden added 2 commits Mar 22, 2019
The SGECluster has no `job_extra` setting like all the other clusters do, which limits its abilities. This PR adds the `job_extra` flag in the same way as it appears in the other cluster files.

xref #219 and #235 which seemed to allude to `SGECluster` having the `job_extra` flag, but no such flag appears to exist.
@Lnaden Lnaden mentioned this pull request Mar 23, 2019
1 of 2 tasks complete
Copy link
Member

guillaumeeb left a comment

Thanks very much for the contribution !

A simple test to validate this would be nice, I encourage you to run it locally. According to Travis logs, you forgot to add an entry in https://github.com/dask/dask-jobqueue/blob/master/dask_jobqueue/jobqueue.yaml.

lesteve added 2 commits Apr 5, 2019
@lesteve lesteve force-pushed the Lnaden:patch-1 branch from 1361da6 to 5021597 Apr 5, 2019
@lesteve

This comment has been minimized.

Copy link
Member

lesteve commented Apr 5, 2019

Merging, thanks a lot @Lnaden!

@lesteve lesteve merged commit 9781a3d into dask:master Apr 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@guillaumeeb

This comment has been minimized.

Copy link
Member

guillaumeeb commented Apr 5, 2019

Glad to see you back around @lesteve, I'm quite taken by work since several weeks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.