Add a job_extra flag to the SGECluster
#256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SGECluster has no `job_extra` setting like all the other clusters do, which limits its abilities. This PR adds the `job_extra` flag in the same way as it appears in the other cluster files. xref dask#219 and dask#235 which seemed to allude to `SGECluster` having the `job_extra` flag, but no such flag appears to exist.
2 tasks
guillaumeeb
reviewed
Mar 29, 2019
There was a problem hiding this comment.
Thanks very much for the contribution !
A simple test to validate this would be nice, I encourage you to run it locally. According to Travis logs, you forgot to add an entry in https://github.com/dask/dask-jobqueue/blob/master/dask_jobqueue/jobqueue.yaml.
|
Merging, thanks a lot @Lnaden! |
|
Glad to see you back around @lesteve, I'm quite taken by work since several weeks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SGECluster has no
job_extrasetting like all the other clusters do, which limits its abilities. This PR adds thejob_extraflag in the same way as it appears in the other cluster files.xref #219 and #235 which seemed to allude to
SGEClusterhaving thejob_extraflag, but no such flag appears to exist.