Add missing parameter docstring and removed unused parameter.#277
Merged
Merged
Conversation
Also reordered docstrings to match signature order.
guillaumeeb
reviewed
Jun 8, 2019
Member
guillaumeeb
left a comment
guillaumeeb
left a comment
There was a problem hiding this comment.
Looks fine, but just one interrogation.
| extra=None, | ||
| env_extra=None, | ||
| log_directory=None, | ||
| walltime=None, |
Member
There was a problem hiding this comment.
Just one question about this removal: shouldn't we instead remove it from all JobqueueCluster impl?
Member
|
Let's merge this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log_directoryandconfig_namewere not in the docstringJobQueueCluster(already in derived classes)