Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parameter docstring and removed unused parameter. #277

Merged
merged 1 commit into from Jun 20, 2019

Conversation

@lesteve
Copy link
Member

lesteve commented Jun 6, 2019

  • log_directory and config_name were not in the docstring
  • walltime parameter is not used inside JobQueueCluster (already in derived classes)
  • Moved down python in the docstring to match signature order.
Also reordered docstrings to match signature order.
Copy link
Member

guillaumeeb left a comment

Looks fine, but just one interrogation.

@@ -174,7 +178,6 @@ def __init__(
extra=None,
env_extra=None,
log_directory=None,
walltime=None,

This comment has been minimized.

Copy link
@guillaumeeb

guillaumeeb Jun 8, 2019

Member

Just one question about this removal: shouldn't we instead remove it from all JobqueueCluster impl?

@guillaumeeb

This comment has been minimized.

Copy link
Member

guillaumeeb commented Jun 20, 2019

Let's merge this for now.

@guillaumeeb guillaumeeb merged commit 37ab0ea into dask:master Jun 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.