Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to @willirath tutorial #290

Merged
merged 5 commits into from Jul 16, 2019

Conversation

@lesteve
Copy link
Member

lesteve commented Jul 16, 2019

I added them on the docs and in the README. Any comments, let me know!

This is how it looks on the documentation generated locally:

image.

@lesteve

This comment has been minimized.

Copy link
Member Author

lesteve commented Jul 16, 2019

I wanted to say it is slightly weird to have the Tutorial non-section before the "Getting started" but I figure it is better to make the tutorial prominent rather than hidden in a sub-page.

Copy link
Member

guillaumeeb left a comment

This is a fantastic idea to promote @willirath's work and demonstrate dask-jobqueue use!

@willirath

This comment has been minimized.

Copy link
Collaborator

willirath commented Jul 16, 2019

Thanks for adding these!

There's a DOI now: https://doi.org/10.5281/zenodo.3337784

But the look and feel is much nicer in the Github repo. So I'm not sure which to better include. The DOI is much more stable, though.

@willirath

This comment has been minimized.

Copy link
Collaborator

willirath commented Jul 16, 2019

I wanted to say it is slightly weird to have the Tutorial non-section before the "Getting started" but I figure it is better to make the tutorial prominent rather than hidden in a sub-page.

What about putting it in a Tutorials page under "Detailed Use"? There, we could also link the video from the front page and the slides / video of @andersy005's SciPy2019 talk.

@lesteve

This comment has been minimized.

Copy link
Member Author

lesteve commented Jul 16, 2019

I haven't had time to catch up with SciPy I have to admit (just watching Matt's talk now). My not super strong opinions:

  • I'd be in favour to make the tutorial(s) prominent. So maybe a reasonable compromise is to have a link with tutorials on the main documentation page that goes to a "Tutorials" sub-section.
  • I'd go for the github repo rather than the DOI. user-friendly trumps stability in this particular case.
@willirath

This comment has been minimized.

Copy link
Collaborator

willirath commented Jul 16, 2019

Sounds great!

@lesteve lesteve force-pushed the lesteve:add-willirath-tutorial branch from d529eb2 to 569e5dc Jul 16, 2019
@lesteve

This comment has been minimized.

Copy link
Member Author

lesteve commented Jul 16, 2019

Pushed an update. I put this in the "Getting started" section, because I feel this is where I would expect a tutorial to show up rather than "detailed use". Let me know what you think.

image

@willirath

This comment has been minimized.

Copy link
Collaborator

willirath commented Jul 16, 2019

Looks great!

@willirath

This comment has been minimized.

Copy link
Collaborator

willirath commented Jul 16, 2019

If there's no objections within the next hour or so, I'd merge.

lesteve added 2 commits Jul 16, 2019
@willirath willirath merged commit 299bc92 into dask:master Jul 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lesteve lesteve deleted the lesteve:add-willirath-tutorial branch Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.