Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix ClusterManager.dashboard_link #291
Specifically, fixes this error in the
File "/miniconda/envs/myenv/lib/python3.7/site-packages/dask_jobqueue/deploy/cluster_manager.py", line 146, in dashboard_link port = self.scheduler.services["bokeh"].port KeyError: 'bokeh'
I think it's fine to do
Would it be possible and not too hard to add a test for this? Currently our tests are passing with distributed >= 2, e.g. https://travis-ci.org/dask/dask-jobqueue/jobs/560794336.
Thanks a lot for the additional test!
format_dashboard_link has been added in distributed 2.1 in this commit dask/distributed@bf65f7a. I am in favour of requiring
@guillaumeeb any strong objections on this one?