Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove threads from JobQueueCluster arguments. #297

Merged
merged 1 commit into from Jul 25, 2019

Conversation

@lesteve
Copy link
Member

lesteve commented Jul 23, 2019

Trying to use threads has raised an informative error message since dask-jobqueue 0.3 (about one year), more precisely this commit: d4d4732.

I think we can safely remove this. Objections more than welcome!

As a reminder: this was when we migrated from processes and threads (implicitly per dask worker) to cores and processes.

Trying to use threads has raised an informative error message since dask-jobqueue 0.3 (about one year).
@@ -223,9 +207,6 @@ def __init__(
if shebang is None:
shebang = dask.config.get("jobqueue.%s.shebang" % config_name)

if dask.config.get("jobqueue.%s.threads", None):

This comment has been minimized.

Copy link
@lesteve

lesteve Jul 23, 2019

Author Member

Note: having threads: something in a dask config would warn and be ignored before this PR. After this PR, it will be silently ignored.

@lesteve

This comment has been minimized.

Copy link
Member Author

lesteve commented Jul 25, 2019

Merging this one.

@lesteve lesteve merged commit 4ceae60 into dask:master Jul 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lesteve lesteve deleted the lesteve:remove-threads-from-cluster-args branch Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.