Remove threads from JobQueueCluster arguments.#297
Merged
lesteve merged 1 commit intodask:masterfrom Jul 25, 2019
Merged
Conversation
Trying to use threads has raised an informative error message since dask-jobqueue 0.3 (about one year).
lesteve
commented
Jul 23, 2019
| if shebang is None: | ||
| shebang = dask.config.get("jobqueue.%s.shebang" % config_name) | ||
|
|
||
| if dask.config.get("jobqueue.%s.threads", None): |
Member
Author
There was a problem hiding this comment.
Note: having threads: something in a dask config would warn and be ignored before this PR. After this PR, it will be silently ignored.
Member
Author
|
Merging this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to use
threadshas raised an informative error message since dask-jobqueue 0.3 (about one year), more precisely this commit: d4d4732.I think we can safely remove this. Objections more than welcome!
As a reminder: this was when we migrated from
processesandthreads(implicitly per dask worker) tocoresandprocesses.