Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Dask 2.3.0 release #313

Merged
merged 5 commits into from Aug 15, 2019
Merged

Prepare for Dask 2.3.0 release #313

merged 5 commits into from Aug 15, 2019

Conversation

@jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Aug 14, 2019

This is just to test against the current master branch of dask/dask and dask/distributed prior to releasing 2.3.0 upstream

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Aug 14, 2019

Thanks for handling this @jrbourbeau . I hope that this work all gets replaced in the near-to-moderate future with the SpecCluster rewrite (#307) , but until then it's quite nice to maintain continuity.

@jrbourbeau
Copy link
Member Author

@jrbourbeau jrbourbeau commented Aug 14, 2019

Thanks for pointing me to #307, looking forward to seeing it included

until then it's quite nice to maintain continuity

Just to be clear, you mean continuity with distributed right? Fortunately, it looks like adding a scheduler_info attribute was the only addition needed for compatibility with the current distributed master

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Aug 15, 2019

@jrbourbeau
Copy link
Member Author

@jrbourbeau jrbourbeau commented Aug 15, 2019

the dask-jobqueue package becomes much smaller
and requires less maintenance

+1 😄

Things look good here (the CI is passing against upstream masters), so I'll go ahead and revert back to testing against the latest release

@mrocklin mrocklin merged commit 383c368 into dask:master Aug 15, 2019
1 check passed
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Aug 15, 2019

Thanks @jrbourbeau !

@jrbourbeau jrbourbeau deleted the test-master branch Aug 15, 2019
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Aug 18, 2019

@guillaumeeb is it ok if I push out a release for dask 2.3 compatibility?

@guillaumeeb
Copy link
Member

@guillaumeeb guillaumeeb commented Aug 18, 2019

Sure! No problem from me. We have to ensure that jobqueue is compatible with the latest Dask version!

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Aug 18, 2019

@lesteve
Copy link
Member

@lesteve lesteve commented Aug 19, 2019

Thanks for this! FYI I pushed a minor change in the changelog to make it more clear that dask-jobqueue 0.6.3 is compatible with dask 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants