Merged
Conversation
guillaumeeb
reviewed
Sep 24, 2019
Member
guillaumeeb
left a comment
guillaumeeb
left a comment
There was a problem hiding this comment.
This looks good! Just made a few comments.
Member
Author
|
Thanks for the feedback @guillaumeeb . I think I've responded to all of your suggestions. |
Member
|
Thanks @mrocklin ! |
Member
Author
|
Thanks for the review!
…On Wed, Sep 25, 2019 at 2:26 PM Guillaume Eynard-Bontemps < ***@***.***> wrote:
Thanks @mrocklin <https://github.com/mrocklin> !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#340?email_source=notifications&email_token=AACKZTGPO3TBLSOGDPA7ISTQLO3ORA5CNFSM4IZL555KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7TB34Y#issuecomment-535174643>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACKZTEVVE4E7CX45YCZQKTQLO3ORANCNFSM4IZL555A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates our interactive/Jupyter documentation. We focus a bit more now on JupyterLab, and remove the link to the pangeo docs, which was a bit stale.