Update .scale() and .adapt() docstrings#346
Merged
Merged
Conversation
jhamman
reviewed
Oct 7, 2019
jhamman
left a comment
Member
There was a problem hiding this comment.
Thanks @andersy005 for the doc improvements! Just one suggestion to make the adaptive scaling method a bit clearer.
|
|
||
| Parameters | ||
| ---------- | ||
|
|
Member
There was a problem hiding this comment.
I think we should also include the minimum/maximum arguments here. I suspect most users will interact with these regularly and I think chasing the arguments through to dask.distributed.Adaptive will end up being annoying.
Member
Author
|
When you get time, this is ready for another look. |
jhamman
reviewed
Oct 8, 2019
Comment on lines
+519
to
+522
| minimum_cores : int | ||
| Minimum number of cores for the cluster | ||
| maximum_cores : int | ||
| Maximum number of cores for the cluster |
Member
There was a problem hiding this comment.
I don't think we want the _cores in these names. These will be passed through to https://distributed.dask.org/en/latest/api.html#adaptive which just uses minimum/maximum.
Member
Author
There was a problem hiding this comment.
👍 Fixed it ( I think :))
jhamman
approved these changes
Oct 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #344 (comment)
I am not sure what's the right way to include the information from
distributed's SpecClusterwithout copying and pasting it into the new docstrings:adapt(): Updatedadapt(): Old version