-
-
Notifications
You must be signed in to change notification settings - Fork 134
Update .scale()
and .adapt()
docstrings
#346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andersy005 for the doc improvements! Just one suggestion to make the adaptive scaling method a bit clearer.
dask_jobqueue/core.py
Outdated
|
||
Parameters | ||
---------- | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also include the minimum/maximum arguments here. I suspect most users will interact with these regularly and I think chasing the arguments through to dask.distributed.Adaptive will end up being annoying.
When you get time, this is ready for another look. |
dask_jobqueue/core.py
Outdated
minimum_cores : int | ||
Minimum number of cores for the cluster | ||
maximum_cores : int | ||
Maximum number of cores for the cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want the _cores
in these names. These will be passed through to https://distributed.dask.org/en/latest/api.html#adaptive which just uses minimum
/maximum
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Fixed it ( I think :))
Addresses #344 (comment)
I am not sure what's the right way to include the information from
distributed's SpecCluster
without copying and pasting it into the new docstrings:adapt()
: Updatedadapt()
: Old version