Fix mysql version to get Slurm CI green#423
Conversation
|
qed ;) |
|
I suggest we merge this immediately and have a closer look at making these environment changes easier to spot in a separate PR. (See #424.) |
Just so I understand wether I'm kind of blind here or not: Did you get this info directly from the Travis logs? Or did you check what happened with the relevant images on Docker hub? |
|
I checked the Travis log because I wanted to get #420 done and just looked at the date when it broke. I first thought it was the slurm image but it only changed the README 2 weeks ago. Because the other stuff (dependencies) seemed too difficult, I checked the only other image referenced and there was a version bumb for the tag shown on Docker hub that exactly coincided (6 days or so) with the the time Travis broke. So I gave it a quick shot and then pushed it. I actually did not know anyone was working on it until I pushed it: I was just frustrated that my PR wasn't green :) . |
|
BTW: I still have no clue what actually happens. It was just naive luck and someone should probably look into it. But maybe it is rather an issue for the docker image (don't think it depends on anything specific). |
|
I am very happy to see this green, thanks a lot! I am also very happy not to look into what changed in mysql and to ignore this for now ... there is also something related to Travis-CI because I could not reproduce locally ... |
Picked up from dask/dask-jobqueue#423
I just checked what happened when suddenly the slurm CI stopped working. The only relevant thing I saw was a version bump in the mysql docker image.
I'll close this PR immediately if Travis does not work...