Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mysql version to get Slurm CI green #423

Merged
merged 1 commit into from May 3, 2020

Conversation

riedel
Copy link
Member

@riedel riedel commented May 2, 2020

I just checked what happened when suddenly the slurm CI stopped working. The only relevant thing I saw was a version bump in the mysql docker image.

I'll close this PR immediately if Travis does not work...

@riedel
Copy link
Member Author

riedel commented May 2, 2020

qed ;)

@willirath
Copy link
Collaborator

I suggest we merge this immediately and have a closer look at making these environment changes easier to spot in a separate PR. (See #424.)

@willirath
Copy link
Collaborator

The only relevant thing I saw was a version bump in the mysql docker image.

Just so I understand wether I'm kind of blind here or not: Did you get this info directly from the Travis logs? Or did you check what happened with the relevant images on Docker hub?

@riedel
Copy link
Member Author

riedel commented May 3, 2020

I checked the Travis log because I wanted to get #420 done and just looked at the date when it broke. I first thought it was the slurm image but it only changed the README 2 weeks ago. Because the other stuff (dependencies) seemed too difficult, I checked the only other image referenced and there was a version bumb for the tag shown on Docker hub that exactly coincided (6 days or so) with the the time Travis broke. So I gave it a quick shot and then pushed it. I actually did not know anyone was working on it until I pushed it: I was just frustrated that my PR wasn't green :) .

@riedel
Copy link
Member Author

riedel commented May 3, 2020

BTW: I still have no clue what actually happens. It was just naive luck and someone should probably look into it. But maybe it is rather an issue for the docker image (don't think it depends on anything specific).

@lesteve
Copy link
Member

lesteve commented May 3, 2020

I am very happy to see this green, thanks a lot!

I am also very happy not to look into what changed in mysql and to ignore this for now ... there is also something related to Travis-CI because I could not reproduce locally ...

@lesteve lesteve changed the title speculative PR reverting mysql version to get slurm CI back to work Fix mysql version to get Slurm CI green May 3, 2020
@lesteve lesteve merged commit e5177cc into dask:master May 3, 2020
ocaisa pushed a commit to E-CAM/jobqueue_features that referenced this pull request May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants