Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak name in cluster.job_script(). #439

merged 1 commit into from Jun 6, 2020


Copy link

@lesteve lesteve commented Jun 6, 2020

I was quite surprised by this in #196 (comment) at one point and forgot that cluster.job_script() is not exactly the same script that is submitted for each submission script that runs dask-worker.

Also dummy-name is easier to grep than name, so easier to reach the comment as well next time I forget about this and need to be remembered.

Copy link
Member Author

lesteve commented Jun 6, 2020

Merging this one (I mostly wanted to make sure that this would not break anything), thanks for your approval @willirath!

@lesteve lesteve merged commit 5ef4ebe into dask:master Jun 6, 2020
@lesteve lesteve deleted the enh-job-script-name branch June 6, 2020 07:18
matyasselmeci added a commit to matyasselmeci/dask-jobqueue that referenced this pull request Jun 16, 2020
* master:
  Tweak name in cluster.job_script(). (dask#439)
  Switch from Travis to GitHub Actions (dask#435)
  Fix name parameters being ignored in Cluster class (dask#398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants