Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fitted values to be concrete #75

Closed
TomAugspurger opened this issue Oct 27, 2017 · 4 comments
Closed

Change fitted values to be concrete #75

TomAugspurger opened this issue Oct 27, 2017 · 4 comments

Comments

@TomAugspurger
Copy link
Member

@TomAugspurger TomAugspurger commented Oct 27, 2017

See #6 (comment) for more. I think the eventual goal is to have a compute keyword in each estimators __init__ method that defaults to True.

Need to update MinMaxScaler and StandardScaler.

@muammar
Copy link

@muammar muammar commented Nov 26, 2019

I know this is old, but have you considering adding an option where one can choose persist over compute?.

@TomAugspurger
Copy link
Member Author

@TomAugspurger TomAugspurger commented Dec 20, 2019

@muammar
Copy link

@muammar muammar commented Jan 3, 2020

The thing is that I have a use case where I preprocess some features, and then I need to restructure them. That means that I compute them, then they are returned to memory by .compute and memory consumption is too high. What I wanted was to have the preprocess features as futures and create the dict from there. Does that make sense?

@TomAugspurger
Copy link
Member Author

@TomAugspurger TomAugspurger commented Jan 25, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants