New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Adds KFold #340

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
2 participants
@thomasjpfan
Contributor

thomasjpfan commented Aug 22, 2018

Addresses some of #269 by adding KFold

@TomAugspurger

This comment has been minimized.

Member

TomAugspurger commented Aug 23, 2018

Looks good at a glance, thanks. While playing with this, I discovered an issue with check_array not handling 1-D X properly, which I can fix independently. Will take a closer look later.

@TomAugspurger

This comment has been minimized.

Member

TomAugspurger commented Aug 29, 2018

Sorry for the delay. This all seems good.

@TomAugspurger TomAugspurger merged commit a907c27 into dask:master Aug 29, 2018

6 checks passed

ci/circleci: py27 Your tests passed on CircleCI!
Details
ci/circleci: py36 Your tests passed on CircleCI!
Details
ci/circleci: sklearn_dev Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90.65%)
Details
codecov/project 90.82% (+0.16%) compared to 581026c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@TomAugspurger TomAugspurger referenced this pull request Sep 19, 2018

Open

Add additional CV methods #269

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment