Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow compute=False in ParallelPostFit.score #402

Merged
merged 2 commits into from Oct 12, 2018

Conversation

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Oct 11, 2018

I notice that we are not consistent in the various score methods in our classes. Some of them are lazy, some of them are immediate. None of them support a compute= keyword.

All of the others are trivial to add a compute= keyword, what should the default be? True or False?

@mrocklin mrocklin force-pushed the mrocklin:score-compute branch from dfc7857 to cde293d Oct 11, 2018
@TomAugspurger
Copy link
Member

@TomAugspurger TomAugspurger commented Oct 11, 2018

On estimators, the .score method has to be immediate.

I don't think there's a similar restriction on the scoring functions, so having them be lazy by default makes the most sense to me.

@mrocklin
Copy link
Member Author

@mrocklin mrocklin commented Oct 11, 2018

On estimators, the .score method has to be immediate.

Could it be immediate by default, but still provide a compute=False keyword?

Also, I think that some .score functions may currently be lazy. The dask-glm ones perhaps? I could be wrong though, I haven't actually run these yet, just looked through code.

@TomAugspurger
Copy link
Member

@TomAugspurger TomAugspurger commented Oct 11, 2018

A keyword would be fine.

Not sure about dask-glm. I may be wrong, but I think this would only potentially show up in something like a GridSearchCV(model, params)

Copy link
Member

@TomAugspurger TomAugspurger left a comment

Thanks. I think this all looks good.

@TomAugspurger TomAugspurger merged commit 939ea07 into dask:master Oct 12, 2018
4 of 6 checks passed
4 of 6 checks passed
@codecov
codecov/patch 91.66% of diff hit (target 95.21%)
Details
@codecov
codecov/project 95.19% (-0.03%) compared to 90fbe69
Details
ci/circleci: py27 Your tests passed on CircleCI!
Details
ci/circleci: py36 Your tests passed on CircleCI!
Details
ci/circleci: sklearn_dev Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants