Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix sklearn dev tests #474
There are a couple of recent updates to scikit-learn
To fix these failures, this PR:
First, we could keep two versions of the relevant method and use the appropriate one depending on which
def _transform_col(self, X_col, quantiles, inverse): if SK_VERSION > packaging.version.parse("0.20.2"): return self._transform_col_new(X_col, quantiles, inverse) else: return self._transform_col_legacy(X_col, quantiles, inverse)
Second, we can port over the changes made to
@TomAugspurger do you have a preference here?
Option 2 sounds good to me too. Ready to merge? Thanks a ton for working on this.…
On Sat, Mar 2, 2019 at 10:18 PM James Bourbeau ***@***.***> wrote: I increased the number of samples in the test data for tests/preprocessing/test_data.py::TestQuantileTransformer to avoid the new UserWarning introduced in scikit-learn/scikit-learn#13333 <scikit-learn/scikit-learn#13333> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#474 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHItVoCVeZISurOqv1KwSALBL6vCy_ks5vS00SgaJpZM4bV_Ze> .