This repository has been archived by the owner on Oct 14, 2018. It is now read-only.
Fix dask.base.Base usage to dask.base.is_dask_collection #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterDSteinberg
changed the title
|
Note that once we merge something like this we'll be unable to release until dask/dask releases, which may be for several weeks. |
|
Ok - Thanks for the heads up, @mrocklin , I can work around that timing. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix use of
instance(X, dask.base.Base). Replace withdask.base.is_dask_collection(X). This is a branch off of #61 (but I can change the base branch of this PR if needed).