New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pytest 4 in test suite #4278

Closed
mrocklin opened this Issue Dec 7, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@mrocklin
Copy link
Member

mrocklin commented Dec 7, 2018

If you run our test suite today with pytest four you'll notice that things fail. They've been warning for a while because we've been using pytest markers in old ways. If anyone wants to make a code contribution that doesn't involve much direct knowledge of Dask, switching our our tests to use markers correctly would be welcome.

You can easily recreate these errors by installing pytest==4 and then running our test suite. See http://docs.dask.org/en/latest/develop.html#install and http://docs.dask.org/en/latest/develop.html#run-tests just below.

515hikaru added a commit to 515hikaru/dask that referenced this issue Dec 8, 2018

@515hikaru 515hikaru referenced this issue Dec 8, 2018

Merged

fix #4278 #4280

2 of 2 tasks complete

515hikaru added a commit to 515hikaru/dask that referenced this issue Dec 9, 2018

fix dask#4278
* dask/bytes
* dask/dataframe/io/tests

and change pytest version

515hikaru added a commit to 515hikaru/dask that referenced this issue Dec 9, 2018

fix dask#4278
* dask/bytes
* dask/dataframe/io/tests

and change pytest version

@mrocklin mrocklin closed this in 8bd87a4 Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment