Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute everything required to build the docs #2399

Merged
merged 1 commit into from May 31, 2017

Conversation

Projects
None yet
4 participants
@ghisvail
Copy link
Contributor

commented May 31, 2017

Which includes everything under docs/source and the Makefiles under docs.

Distribute everything required to build the docs
Which includes everything under `docs/source` and the Makefiles under `docs`.
@mrocklin

This comment has been minimized.

Copy link
Member

commented May 31, 2017

This seems fine to me. I'll leave this up for a bit so that others who are more familiar with sphinx can have an opportunity to double check.

Thanks @ghisvail !

@@ -1,11 +1,11 @@
recursive-include dask *.py
recursive-include docs *.rst
recursive-include docs/source *
include docs/Makefile docs/make.bat

This comment has been minimized.

Copy link
@TomAugspurger

TomAugspurger May 31, 2017

Member

Maybe also include docs/README.rst and docs/requirements-docs.txt?

This comment has been minimized.

Copy link
@ghisvail

ghisvail May 31, 2017

Author Contributor

These files aren't part of the nominal set of source files required to generate the Sphinx documentation. Should they be included, it would be the subject of a different PR.

@mrocklin

This comment has been minimized.

Copy link
Member

commented May 31, 2017

I'm just going to go ahead and merge this. It seems like an improvement. Thanks @ghisvail

@mrocklin mrocklin merged commit e57fd00 into dask:master May 31, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ghisvail

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2017

@mrocklin Are there plans to tag a new release soon? I'd want to update and base the Debian packaging on the tarball provided in PyPI (which is the canonical source for upstream releases that Debian recommends), but we have been unable to do it so far due to the incomplete manifest.

Please do let me know.

@ghisvail ghisvail deleted the ghisvail:patch-1 branch Jun 1, 2017

@mrocklin

This comment has been minimized.

Copy link
Member

commented Jun 1, 2017

@sinhrks sinhrks added this to the 0.15.0 milestone Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.