Adds choose method to dask.array.Array #2584
Conversation
Also adds appropriate tests
dask/array/core.py
Outdated
| @@ -1307,6 +1307,10 @@ def ravel(self): | |||
|
|
|||
| flatten = ravel | |||
|
|
|||
| @wraps(np.choose) | |||
| def choose(self, choices): | |||
| return elemwise(variadic_choose, self, *choices) | |||
There was a problem hiding this comment.
Would it make sense for this to just call the function implementation or vice versa?
There was a problem hiding this comment.
That's a good point! It probably makes more sense to just implement choose on a dask Array once. I'll change the PR to have the choose function simply call the choose method on an input dask array.
There was a problem hiding this comment.
Personal preference, but I'd rather have the method call the function (smaller diff too). Not a big deal though, up to you.
There was a problem hiding this comment.
Hey @jcrist, yeah I can switch it so that the method calls the function. I don't have a strong preference either way.
There was a problem hiding this comment.
Just for completeness, the argument for the function calling the method would be to handle inheritance from Dask Array. That said, I have no strong preferences here either and it can always be changed if there is a need.
|
One of the builds failed and it appears to be spurious, would it be possible to get a restart? |
|
Thanks @jrbourbeau! |
Fixes issue #2569. As mentioned in the issue, a
dask.array.choosefunction already exists. This PR copies thedask.array.choosefunctionality into achoosemethod fordask.array.Arrayobjects.